VPN-5884: Add alternate app icons to bundle (#8612)

mozilla-mobile · Nov 21, 2023 · caf2d9a · caf2d9a
1 parent 75db8be
commit caf2d9a
Show file tree

Hide file tree

Showing 10 changed files with 58 additions and 1 deletion.
diff --git a/ios/app/Images.xcassets/AppIcon-black.appiconset/Contents.json b/ios/app/Images.xcassets/AppIcon-black.appiconset/Contents.json
@@ -0,0 +1,14 @@
+{
+  "images" : [
+    {
+      "filename" : "black-1024 1.png",
+      "idiom" : "universal",
+      "platform" : "ios",
+      "size" : "1024x1024"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/ios/app/Images.xcassets/AppIcon-black.appiconset/black-1024 1.png b/ios/app/Images.xcassets/AppIcon-black.appiconset/black-1024 1.png
diff --git a/ios/app/Images.xcassets/AppIcon-green.appiconset/Contents.json b/ios/app/Images.xcassets/AppIcon-green.appiconset/Contents.json
@@ -0,0 +1,14 @@
+{
+  "images" : [
+    {
+      "filename" : "green-1024 1.png",
+      "idiom" : "universal",
+      "platform" : "ios",
+      "size" : "1024x1024"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/ios/app/Images.xcassets/AppIcon-green.appiconset/green-1024 1.png b/ios/app/Images.xcassets/AppIcon-green.appiconset/green-1024 1.png
diff --git a/ios/app/Images.xcassets/AppIcon-light-violet.appiconset/Contents.json b/ios/app/Images.xcassets/AppIcon-light-violet.appiconset/Contents.json
@@ -0,0 +1,14 @@
+{
+  "images" : [
+    {
+      "filename" : "light-violet-1024 1.png",
+      "idiom" : "universal",
+      "platform" : "ios",
+      "size" : "1024x1024"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/ios/app/Images.xcassets/AppIcon-light-violet.appiconset/light-violet-1024 1.png b/ios/app/Images.xcassets/AppIcon-light-violet.appiconset/light-violet-1024 1.png
diff --git a/ios/app/Images.xcassets/AppIcon-violet.appiconset/Contents.json b/ios/app/Images.xcassets/AppIcon-violet.appiconset/Contents.json
@@ -0,0 +1,14 @@
+{
+  "images" : [
+    {
+      "filename" : "violet-1024 1.png",
+      "idiom" : "universal",
+      "platform" : "ios",
+      "size" : "1024x1024"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/ios/app/Images.xcassets/AppIcon-violet.appiconset/violet-1024 1.png b/ios/app/Images.xcassets/AppIcon-violet.appiconset/violet-1024 1.png
diff --git a/src/cmake/ios.cmake b/src/cmake/ios.cmake
@@ -55,6 +55,7 @@ set_target_properties(mozillavpn PROPERTIES
     XCODE_ATTRIBUTE_PRODUCT_NAME "${PROJECT_NAME}"
     XCODE_GENERATE_SCHEME TRUE
     XCODE_ATTRIBUTE_ASSETCATALOG_COMPILER_APPICON_NAME "AppIcon"
+    XCODE_ATTRIBUTE_ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS "YES"
     # Required for this target to be added to the archive?
     XCODE_ATTRIBUTE_INSTALL_PATH "$(LOCAL_APPS_DIR)"
     XCODE_ATTRIBUTE_SKIP_INSTALL "NO"

diff --git a/src/telemetry/metrics.yaml b/src/telemetry/metrics.yaml
@@ -725,7 +725,7 @@ sample:
     bugs:
       - https://mozilla-hub.atlassian.net/browse/VPN-3743
     data_reviews:
-      - TODO
+      - https://github.com/mozilla-mobile/mozilla-vpn-client/pull/5528#pullrequestreview-1262407370
     data_sensitivity:
       - technical
     notification_emails: