VPN-5628: Increase minimum CMake to 3.18 (#8324)

* Update minimum CMake to 3.18
* Remove CMake workarounds for versions < 3.18

CMakeLists.txt

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.18)
 
 message("Configuring for ${CMAKE_GENERATOR}")
 get_property(IS_MULTI_CONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG)
@@ -89,9 +89,6 @@ endif()
 ## Toolchain Setup
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.17)
-    cmake_policy(SET CMP0099 OLD)
-endif()
 
 find_program(PYTHON_EXECUTABLE NAMES python3 python)
 if(MSVC)

addons/CMakeLists.txt

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.18)
 
 project(addons VERSION 1.0.0 LANGUAGES CXX
         DESCRIPTION "Mozilla VPN Addons"

linux/debian/control

@@ -4,7 +4,7 @@ Priority: optional
 Maintainer: mozilla <[email protected]>
 Build-Depends: debhelper (>= 11.2),
                cdbs,
-               cmake (>= 3.16~),
+               cmake (>= 3.18~),
                flex,
                gcc (>=4:8.0.0~),
                g++ (>=4:8.0.0~),

lottie/CMakeLists.txt

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.18)
 
 project(lottie VERSION 1.0.0 LANGUAGES CXX
         DESCRIPTION "Lightweight scalable animations: QML Wrapper library"
@@ -14,9 +14,6 @@ set(CMAKE_AUTOUIC ON)
 if(NOT CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
     set(CMAKE_FOLDER "Lottie")
 endif()
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.17)
-    cmake_policy(SET CMP0099 OLD)
-endif()
 
 add_library(lottie STATIC)
 

tests/functional/addons/CMakeLists.txt

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.18)
 
 project(testing_addons VERSION 1.0.0 LANGUAGES CXX
         DESCRIPTION "Mozilla VPN Addons for Functional Testing"