Update telemetry documentation

mozilla-mobile · Dec 19, 2023 · 63737d8 · 63737d8
1 parent e2a93be
commit 63737d8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/src/networkwatcherimpl.h b/src/networkwatcherimpl.h
@@ -24,7 +24,6 @@ class NetworkWatcherImpl : public QObject {
 
   bool isActive() const { return m_active; }
 
-  ///@TODO should this be removed too?
   enum TransportType {
     TransportType_Unknown = 0,
     TransportType_Ethernet = 1,

diff --git a/src/platforms/android/androidnetworkwatcher.cpp b/src/platforms/android/androidnetworkwatcher.cpp
@@ -16,9 +16,6 @@
 
 namespace {
 Logger logger("AndroidNetworkWatcher");
-
-// constexpr auto VPNNetworkWatcher_CLASS =
-//     "org/mozilla/firefox/vpn/qt/VPNNetworkWatcher";
 }  // namespace
 
 AndroidNetworkWatcher::AndroidNetworkWatcher(QObject* parent)

diff --git a/src/telemetry/metrics.yaml b/src/telemetry/metrics.yaml
@@ -1111,8 +1111,8 @@ sample:
           loss, stddev.
         type: string
       transport:
-        description: The Host network type (i.e wifi or 4g)
-        type: string
+        description: The Host network type (i.e wifi or 4g). Possible values are Unknown, Disconnected, Local, Site, Online
+        type: QNetworkInformation::Reachability
 
   connectivity_stable:
     type: event
@@ -1148,8 +1148,8 @@ sample:
         description: Standard deviation of the ping responses
         type: string
       transport:
-        description: The Host network type (i.e wifi or 4g)
-        type: string
+        description: The Host network type (i.e wifi or 4g). Possible values are Unknown, Disconnected, Local, Site, Online
+        type: QNetworkInformation::Reachability
 
   server_unavailable_error:
     type: event