Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fixes #3466 iOS App Store Connect issues sent via email for Focus/Klar #3654

Conversation

razvanlitianu
Copy link
Contributor

@razvanlitianu razvanlitianu commented Jan 9, 2023

In #2136 There was a change on how localization works for Siri Intents. A new key (Intents.Erase.Title) was introduces to translate the string "Erase". It seems that for some languages the import is not picked up and this is my assumption why the AppStore Connect sends some warnings.
I removed the files with the wrong format and hope they will show at the next import.

@razvanlitianu razvanlitianu requested a review from a team as a code owner January 9, 2023 13:29
@razvanlitianu
Copy link
Contributor Author

Because this is mostly an assumption I need some input from the localization team @Delphine.
I did an experiment where I deleted all the localization files and ran the import script. Of course the missing languages (where the format was wrong) were not imported but it seems for some other languages where it was previously translated, now they were missing.
I guess what I'm trying to understand is how a translator knows I need a new translation for a language? Is the file deletion reflected somewhere?

@razvanlitianu razvanlitianu linked an issue Jan 9, 2023 that may be closed by this pull request
@Delphine
Copy link
Contributor

Thanks for flagging. I'm not really sure what's going on here :/
Can you let me know which locales are missing now? I can then help check if those strings have indeed been localized or not.
Also, what do you mean by "wrong format"?

If they are localized: an iOS engineer will have to look at the Localization Tools and see why it's failing to import - and if that failure happens when importing the localization manually from XCode.

Concerning how a localizer knows that there is a string change or update: you do that by changing the existing string ID.

@razvanlitianu
Copy link
Contributor Author

Thanks for flagging. I'm not really sure what's going on here :/ Can you let me know which locales are missing now? I can then help check if those strings have indeed been localized or not. Also, what do you mean by "wrong format"?

If they are localized: an iOS engineer will have to look at the Localization Tools and see why it's failing to import - and if that failure happens when importing the localization manually from XCode.

Concerning how a localizer knows that there is a string change or update: you do that by changing the existing string ID.

I'm trying to figure it out. If that doesn't work, the suggestion to change the key is really good and I will also try it.

@mergify mergify bot merged commit 24f9955 into main Jan 16, 2023
@mergify mergify bot deleted the rlitianu/3466-iOS-App-Store-Connect-issues-sent-via-email-for-Focus-Klar branch January 16, 2023 13:27
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 14, 2024
… via email for Focus/Klar (mozilla-mobile/focus-ios#3654)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 20, 2024
… issues sent via email for Focus/Klar (mozilla-mobile/focus-ios#3654)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS App Store Connect issues sent via email for Focus/Klar
4 participants