-
Notifications
You must be signed in to change notification settings - Fork 711
[meta] Enable and disable trackers via Allowlist #957
Comments
The desktop version of Firefox has an exception list for tracking protection. We could talk to the GeckoView team in order to decide how we could make use of that list. One complicated thing here is: We do more than just tracking protection (blocking JavaScript, blocking web fonts, ..) and those things are global settings and not limited to a specific site (if we want all those things to use the exception list).. |
/cc @brampitoyo This might be something for past 7.0 |
@pocmo @bbinto As Tracking Protection on Firefox Desktop expands to blocking many other things in the future, the same exception list would also activate and deactivate the un/blocking of slow 3rd party content, crypto-mining, tracking cookies, etc. So having a master toggle still makes sense – except that in our case, this toggle controls so much more. The questions are twofold:
On one end is a UI that allows you to turn each blocker on and off individually. On the other end is a master toggle that turns all the blockers on and off at once. But let’s say that we want to do something inbetween. Maybe 2–3 separate controls instead of just 1. What should they be? A separate control for cookies, and a control for everything else? On permanence: it feels as if we should be proactively protecting our users all the time, and this means doing things like not giving them the ability to add any exception. Want to add? You can, but only once. The next time, you’ll get asked again. We can of course have something more generous. Maybe we’ll have the exception stored for a certain period of time. But now we’re dealing with the problem of, when the user taps “Erase”, not every data is truly cleared. And a secondary problem of Focus becoming more like another browser. While we should give this issue a very careful look beyond v7.0, if we are to look at what Focus already does best, it seems as if building more blockers (especially ones that Firefox and other browsers aren’t willing to build) fits our ‘core competency’ better than building ways to skip blockers. |
Here’s a proposal that gives users:
The way it works:
Since this issue only has to do with building a way to add sites to the whitelist, we will discuss all the elements under Content Blockers itself (trackers, ads, cookies, autoplay, etc.) in #2603. |
I’ve just updated the “Exceptions” screen flow up above, to accurately reflect the newest way to access the page. |
@brampitoyo We chatted about changing the privacy & security options yesterday and having exceptions as one of the options. Do we need updated mockups for the allowlist component before Eng breakdown? |
…elist and Crash reporting
One clarification on the toggle logic: my understanding is that users can add a site to their allowlist by disabling the tracker toggle, but then can only remove a site from their allowlist only by going to the allowlist page in the settings. So for instance if a site is added to allowlist, turning the toggle back on will temporarily enable tracking blocking again, but won't remove the site from the allowlist. Does that match your design/interpretation? @ekager @boek @brampitoyo |
Hm in the current implementation once a site is on the allowlist they can't temporarily turn trackers back on because we are checking the allowlist as the site is loading and then turn on/off blocking. Maybe we could override the list on a single load basis but then what if they click a link on the same domain, should we have it blocking or not? |
@ekager I am ok with the current logic you described. I mainly wanted to make sure that they dont accidentally remove a site from their allowlist by turning the toggle back on. Let's stick with this behaviour and later on revisit and optimize based on usage data. |
I agree @vesta0 it can be confusing. |
Actually, I was thinking that the on and off switch works permanently both ways. Let’s say that you visit a website, and a video doesn’t show up. You know how to fix this. Just open the menu, then turn the “Content Blocking” toggle OFF. The site reloads, and the video plays. Problem solved. The next time you visit this site, do you want the video to show up again, or not? My educated guess is that, users who have deliberately turned “Content Blocking” OFF will want to keep it on the OFF position indefinitely. To toggle it over and over again would be annoying. What about turning the toggle back ON? Usually, there isn’t a good everyday use case for this. The site has been fixed. Everything works. So why risk breaking it again? Nevertheless, let’s think of a scenario. The site is starting to misbehave again. The video that you want is playing every single time. But today, the site has put in an unskippable interstitial video ad that takes over the whole screen. It’s so annoying, that you want to block again. You also know how to do this. Open the menu, then toggle “Content Blocking” back ON. When you want to turn blocking OFF, you want it to stick permanently. The question is: when you want to turn blocking back on, do you want it to stick permanently or not? My argument is that you want it to be permanent, and there are a few reasons why:
There’s an argument to be made for a toggle that works like uBlock Origin:
Just to reiterate our toggle models:
|
Verified UI and functionality on Nightly. Created manual test cases. |
Why/User Benefit/User Problem
What / Requirements
Acceptance Criteria (how do I know when I’m done?)
Blocks or does not block items based on the list
Disabling content blocking adds the site to the allowlist
-Content blocking is re-enabled once the user navigates to another site
https://appbot.co/apps/926238-firefox-focus-the-privacy-browser/reviews/475076741
http://appbot.co/apps/926238-firefox-focus-the-privacy-browser/reviews/488627651
and here
The text was updated successfully, but these errors were encountered: