Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #9278 [v97]: Telemetry for tab navigation buttons #9785

Merged

Conversation

nishant2718
Copy link
Contributor

Overview

PR addresses this JIRA ticket and #9278. Data Review notes will be posted in the comments soon.

@nishant2718 nishant2718 requested a review from lmarceau January 14, 2022 20:27
@nishant2718 nishant2718 force-pushed the feature/FXIOS-3263-nav-telemetry branch from d4e0a1b to 2edc09d Compare January 14, 2022 20:29
Client/Frontend/Browser/Tab.swift Outdated Show resolved Hide resolved
Client/Frontend/Browser/Tab.swift Outdated Show resolved Hide resolved
@nishant2718
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?

It answers how our users navigate within tabs.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

This provides information about user behavior on navigation within tabs.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?

Current methods have not previously recorded this type of telemetry.

4) Can current instrumentation answer these questions?

No.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Did a user tap/long press the back button in the toolbar? Category 2 #9278
Did a user tap/long press the forward button in the toolbar? Category 2 #9278
Did a user tap the refresh button in the toolbar? Category 2 #9278
Did a user navigate to a previous link in tab history but swiping from the left edge of the screen? Category 2 #9278

6) How long will this data be collected? Choose one of the following:

Until 2022-07-01.

7) What populations will you measure?

All release channels and locales.

8) If this data collection is default on, what is the opt-out mechanism for users?

Users can opt out of of data collection by disabling Usage and technical data from Settings → Send Usage Data.

9) Please provide a general description of how you will analyze this data.

Glean

10) Where do you intend to share the results of your analysis?

Only on Glean, mobile teams and BD have internal access.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?

No.

@nishant2718 nishant2718 force-pushed the feature/FXIOS-3263-nav-telemetry branch from 2edc09d to 033f780 Compare January 18, 2022 15:52
@nishant2718
Copy link
Contributor Author

@dnarcese for data review

@nishant2718 nishant2718 changed the title Add #9278 [v97]: Telemetry for tab toolbar navigation buttons Add #9278 [v97]: Telemetry for tab navigation buttons Jan 18, 2022
@dnarcese
Copy link
Contributor

r+

Data Review Form

1) Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, telemetry is documented at https://dictionary.telemetry.mozilla.org/apps/firefox_ios

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Firefox iOS provides data controls in the app settings

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

This should be re-reviewed w/ Ashley Thomas every 6mo

4) Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2

5) Is the data collection request for default-on or default-off?

Default on

6) Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7) Is the data collection covered by the existing Firefox privacy notice?

Yes

8) Does the data collection use a third-party collection tool?

No

@nishant2718 nishant2718 merged commit 8630b3d into mozilla-mobile:main Jan 18, 2022
@nishant2718 nishant2718 deleted the feature/FXIOS-3263-nav-telemetry branch January 18, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants