Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy appservices local dev resources, rather than symlinking. #8081

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

rfk
Copy link
Contributor

@rfk rfk commented Mar 5, 2021

Now that we're using carthage copy-framework to bundle the Application
Services framework, it doesn't seem possible to use a symlink for local
development - carthage tries to turn it into a relative path and gets
mightily confused.

As an alternative, this modifies the local-dev scripts to rsync across
the build artifacts into ./Carthage/Build/. It's less convenient than
before, but at least it works...

Now that we're using `carthage copy-framework` to bundle the Application
Services framework, it doesn't seem possible to use a symlink for local
development - carthage tries to turn it into a relative path and gets
mightily confused.

As an alternative, this modifies the local-dev scripts to rsync across
the build artifacts into `./Carthage/Build/`. It's less convenient than
before, but at least it works...
@rfk
Copy link
Contributor Author

rfk commented Mar 10, 2021

/cc @nishant2718, this was a little tweak I found useful while trying to test some local appservices changes.

@nbhasin2 nbhasin2 merged commit 0932c59 into mozilla-mobile:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants