Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-6661 [v116] EnhancedTrackingProtection coordinator #15034

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Add FXIOS-6661 [v116] EnhancedTrackingProtection coordinator #15034

merged 4 commits into from
Jun 20, 2023

Conversation

aalaaeid
Copy link
Contributor

@aalaaeid aalaaeid commented Jun 17, 2023 •
edited by lmarceau
Loading

Jira ticket
Github issue

Description

Add EnhancedTrackingProtection coordinator

Pull requests checks where applicable

  • Fill in the three TODOs above (tickets number and description of your work)
  • The PR name follows our naming guidelines
  • Accessibility implemented and tested (minimum Dynamic Text and VoiceOver)
  • Unit tests written and passing
  • Documentation / comments for complex code and public methods

@aalaaeid aalaaeid requested a review from a team as a code owner June 17, 2023 20:03
@aalaaeid aalaaeid requested a review from yoanarios June 17, 2023 20:03
@lmarceau lmarceau changed the title Add FXIOS-14888 [v116] EnhancedTrackingProtection coordinator Add FXIOS-6661 [v116] EnhancedTrackingProtection coordinator Jun 19, 2023
lmarceau
lmarceau reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@lmarceau lmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failed due to:
Screenshot 2023-06-19 at 10 05 47 AM

It seems the target membership needs to be ClientTests instead of AccountTests for EnhancedTrackingProtectionCoordinatorTests.swift
Screenshot 2023-06-19 at 10 07 30 AM

@aalaaeid aalaaeid requested a review from a team as a code owner June 19, 2023 20:25
@aalaaeid aalaaeid requested a review from jjSDET June 19, 2023 20:25
@aalaaeid aalaaeid force-pushed the ae/addETPCoordinator branch from 3b004fe to 2fca836 Compare June 19, 2023 20:29
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 2 files

Generated by 🚫 Danger Swift against 3d6fbde

@lmarceau lmarceau merged commit caf61e3 into mozilla-mobile:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau lmarceau left review comments

@yoanarios yoanarios yoanarios approved these changes

@adudenamedruby adudenamedruby adudenamedruby approved these changes

@jjSDET jjSDET Awaiting requested review from jjSDET jjSDET was automatically assigned from mozilla-mobile/fxios-automation-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aalaaeid @mobiletest-ci-bot @adudenamedruby @lmarceau @yoanarios