Bugfix FXIOS-5344 [v109] fixes search highlights getting interrupted #12578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #12530
Moves the
places.interruptReader()
to only run if search highlights are disabled and we are running the new places history. The interrupt helps make sure we aren't running too many long-running queries back to back againstplaces.db
without interruption.Additionally, optimizes the search highlights case. Previously, we would always run the normal history query, but then discard its result if search highlights are enabled. Now, we only run the search query if search highlights are disabled.
Some more context on the bug in the issue.
Possibly for a follow-up:
cc @lmarceau @badboy