Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-5042 [v109] Use inputTypeIsCompatibleWithUsername function from shared logic file #12451

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Refactor FXIOS-5042 [v109] Use inputTypeIsCompatibleWithUsername function from shared logic file #12451

merged 2 commits into from
Nov 25, 2022

Conversation

issammani
Copy link
Collaborator

@issammani issammani commented Nov 22, 2022 •
edited by lmarceau
Loading

FXIOS-5042

This PR:

  • Uses inputTypeIsCompatibleWithUsername function from shared logic file. See corresponding desktop code.
  • Adds import alias for Assests directory.

@issammani
Copy link
Collaborator Author

Tagging @nbhasin2 @galich for review.

@lmarceau lmarceau requested a review from nbhasin2 November 22, 2022 14:14
@issammani
Copy link
Collaborator Author

Adding @DimiDL for review as well.

galich
galich approved these changes Nov 24, 2022
View reviewed changes
Copy link

@galich galich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @issammani !

@nbhasin2 nbhasin2 changed the title Refactor FXIOS-5042 [v108] Use inputTypeIsCompatibleWithUsername function from shared logic file Refactor FXIOS-5042 [v109] Use inputTypeIsCompatibleWithUsername function from shared logic file Nov 25, 2022
@nbhasin2 nbhasin2 merged commit e0666c8 into mozilla-mobile:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

@galich galich galich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issammani @galich @nbhasin2