-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes SYNC-3364 [v110] history configuration cleanup #12420
Removes SYNC-3364 [v110] history configuration cleanup #12420
Conversation
This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? |
c14743c
to
2cb4639
Compare
Got around to removing the dead tests and refactoring any history tests to test places properly - next step will be to split this apart a little and make sure there is enough context on what's going on here |
4d63932
to
b3bf36a
Compare
This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A short self-review as I clean things up more
If anyone is following along, I want to repeat that I have no intention of landing all of this at once
The idea is to breakdown which of those cleanups are ones we want and land those one by one
Client/Frontend/Home/TopSites/DataManagement/TopSiteHistoryManager.swift
Show resolved
Hide resolved
75e9e80
to
f66952c
Compare
7fbcb48
to
d34a349
Compare
Swiftlint warnings not related to this PR, will be fixed with changes here |
This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? |
2d6b24b
to
363e307
Compare
@tarikeshaq have you already done a walkthrough of this PR? |
@nbhasin2 I did a walk-through with @OrlaM and @lmarceau, some notes as well in https://docs.google.com/document/d/1R7Fko3aPc9bNHc3FazSdHJlcPk1LZeX8lbvkzTvDUxA/edit and https://docs.google.com/document/d/11smb_1bXMkHDHA-ZwdsWIoHFeGXgDajO2S4nYmcyrPQ/edit |
Perfect @tarikeshaq, I will skim through this although you are in good hands of @OrlaM and @lmarceau for the review 🙂 |
This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, otherwise looks good.
At some point next week we should create a build off this branch to send to QA for testing.
Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
Client/Frontend/Home/TopSites/DataManagement/TopSiteHistoryManager.swift
Show resolved
Hide resolved
07e6e17
to
9de201c
Compare
The special build was done testing with task #12674, I think this is ready to be merged (but we'll need the experiment result before that @tarikeshaq ?) |
Thanks @lmarceau!! Experiment results are in, and I think we should land this. I cover the results in https://docs.google.com/document/d/1fC55c9m66E18ztQwEFhfmesJdSWfes3eSQLcfaq4Kjo/edit TLDR:
|
This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? |
5f853d7
to
aaab3ee
Compare
2122b89
to
4021983
Compare
Disclaimer
Overview
With history using Application services places (expected to rollout remotely in 108) we can start cleaning up a lot of legacy code! This PR is incomplete needs a TON of testing and is a work in progress. With that preface, here's what's included:
Removal of configuration
Removal of old APIs
Refactoring of SQLiteHistory
Renaming SQLiteHistory to BrowserDBSQLite
BrowserDBSQLite
so it's a bit more generic.Removing Caching for top sites
Deletion of dead code and redundant tests
Refactors not in this PR
There are a few changes that I intentionally left out of here, because I believe they have a bigger scope or should be done even more carefully. THIS IS AN INCOMPLETE LIST AND I WILL KEEP ADDING TO IT