-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-5207 [v108] Telemetry for logins component key regeneration logic #12306
Add FXIOS-5207 [v108] Telemetry for logins component key regeneration logic #12306
Conversation
How often do we regenerate the logins encryption key on iOS? Why do we regenerate it?
Regenerating the key means loss of all local logins data. If this happens often then we want to investigate why to try to avoid it.
No alternatives.
No.
This collection is documented in the Glean Dictionary at https://dictionary.telemetry.mozilla.org/
I want this data to be collected indefinitely to monitor for any potential data loss
All channels in all countries in all locales, for Firefox iOS
Standard Firefox telemetry controls
Track the error rates. If we determine they are too high, then we will attempt to address the causes.
The SACI and iOS teams
No |
Oh, forgot I need to request data review. @travis79 let me know if this should land in your queue or someone else's. Thanks! |
dc891fe
to
afd3ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - data review remaining
afd3ac1
to
48bb074
Compare
0b0dde0
to
97509b3
Compare
97509b3
to
524ea2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Data Review
Yes, through the metrics.yaml file and the Glean Dictionary.
Yes, through the "Send Usage Data" preference in the application settings.
Permanent collection to be monitored by @lougeniaC64
Category 1, Technical data
Default-on
No
Yes
No Resultdata-review+ |
Closing and reopening to try BR |
Jira ticket
#12308
Adding telemetry to the key regeneration logic in the logins component in order to monitor the rates in which we recreate the encryption key. This will help us surface any spikes in encryption key errors similar to the ones we previously noticed.
With the exception of some naming changes suggested by Glean, this is identical to what we have implemented for Android (see here).