Feature FXIOS-7024 [v108] Add feature to reload web page from source, ignoring cache #12231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MincDev
changed the title
lmarceau
requested changes
Oct 26, 2022
Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetProtocol.swift
Outdated
Show resolved
Hide resolved
…yboard shortcut to reload without cache.
lmarceau
reviewed
Oct 26, 2022
Client/Frontend/Browser/BrowserViewController/BrowserViewController+KeyCommands.swift
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts when rebasing. Could you fix it @MincDev? |
…github.com/MincDev/firefox-ios into feature/7024-feature-reload-ignoring-cache
lmarceau
reviewed
Oct 28, 2022
Client/Frontend/Browser/BrowserViewController/BrowserViewController+KeyCommands.swift
Outdated
Show resolved
Hide resolved
These suggestions were minor formatting fixes and code improvements by @Imarceau Co-authored-by: lmarceau <[email protected]>
|
This pull request has conflicts when rebasing. Could you fix it @MincDev? |
…then comitted again
|
@lmarceau I believe it should be resolved now. I had to recommit indentation fix, because after pulling your suggested changes it was back on tabs, and I accidentally committed like that again. It was probably since you made changes on my original tab indented code? Not sure, but all should be okay now :) |
|
Build is green here |
lmarceau
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #7024 by adding a feature to allow users to reload the page, ignoring the cached site data. This feature adds an extra menu button on the long press of the reload button. The additional button allows a "hard refresh" of the page similar to "Ctrl + F5" on desktop.