Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-4856 [v106] Crash when trying to shared downloaded PDF #11861

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Bugfix FXIOS-4856 [v106] Crash when trying to shared downloaded PDF #11861

merged 1 commit into from
Sep 9, 2022

Conversation

TwizzyIndy
Copy link
Contributor

@TwizzyIndy TwizzyIndy commented Sep 9, 2022

Referenced Issue: #11777 FXIOS-4856

Please review my PR @lmarceau. Thanks.

@lmarceau lmarceau self-requested a review September 9, 2022 16:10
@lmarceau lmarceau changed the title BugFix FXIOS-11777 [v104] : Crash when trying to shared downloaded PDF Bugfix FXIOS-4856 [v106] Crash when trying to shared downloaded PDF Sep 9, 2022
@lmarceau
Copy link
Contributor

lmarceau commented Sep 9, 2022

Build is green here
Screen Shot 2022-09-09 at 12 13 36 PM

@lmarceau
Copy link
Contributor

lmarceau commented Sep 9, 2022

For context for others, this change is good as this is what we had before changing for the combine menu in PR. We were taking tab.url, moving to new menu introduced this error. Also tested and seems to be fine

Screen Shot 2022-09-09 at 12 18 55 PM

Copy link
Contributor

@lmarceau lmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TwizzyIndy !

@lmarceau lmarceau merged commit 35e138e into mozilla-mobile:main Sep 9, 2022
ecotopian pushed a commit to ecosia/ios-browser that referenced this pull request Nov 22, 2022
ecotopian pushed a commit to ecosia/ios-browser that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants