Bugfix FXIOS-11702 [v105] Fix syncClientsThenTabs function
#11692
Conversation
lougeniaC64
changed the title
syncClientsThenTabs functionsyncClientsThenTabs function
|
@nbhasin2 This is the tabs syncing bug we discussed. Just to reiterate for posterity, the bug that was introduced in v103 prevented tabs from being synced after the "Sync Now" button was clicked in the remote tabs panel. Because full syncs were unaffected (timed syncs, clicking "Sync Now" from the settings menu, etc.) this issue was masked and might seem like a delay in tabs syncing to the user. |
Providers/Profile.swift
Outdated
| return self.syncSeveral( | ||
| why: .user, | ||
| synchronizers: | ||
| ("clients", self.syncClientsWithDelegate), | ||
| ("tabs", self.syncTabsWithDelegate)) >>== { statuses in | ||
| let status = statuses.find { "tabs" == $0.0 } | ||
| return deferMaybe(status!.1) | ||
| } |
There was a problem hiding this comment.
nit: Indentation
It will look odd on github but its more readable on the XCode side
| return self.syncSeveral( | |
| why: .user, | |
| synchronizers: | |
| ("clients", self.syncClientsWithDelegate), | |
| ("tabs", self.syncTabsWithDelegate)) >>== { statuses in | |
| let status = statuses.find { "tabs" == $0.0 } | |
| return deferMaybe(status!.1) | |
| } | |
| return self.syncSeveral(why: .user, synchronizers: ("clients", self.syncClientsWithDelegate), | |
| ("tabs", self.syncTabsWithDelegate)) >>== { | |
| statuses in | |
| let status = statuses.find { "tabs" == $0.0 } | |
| return deferMaybe(status!.1) | |
| } |
There was a problem hiding this comment.
I think it might be something like this because your first line will be too long.
return self.syncSeveral(
why: .user,
synchronizers:
("clients", self.syncClientsWithDelegate),
("tabs", self.syncTabsWithDelegate)
) >>== { statuses in
let status = statuses.find { "tabs" == $0.0 }
return deferMaybe(status!.1)
}
There was a problem hiding this comment.
yeah, that makes sense I just quickly typed on github and likely made it worse ha
| let status = statuses.find { "tabs" == $0.0 } | ||
| return deferMaybe(status!.1) |
There was a problem hiding this comment.
It would be good to write a comment to further explain what this does.
lougeniaC64
force-pushed
the
fix-remote-panel-sync
branch
2 times, most recently
from
9bbbbf9 to
8290da7
Compare
lougeniaC64
force-pushed
the
fix-remote-panel-sync
branch
from
8290da7 to
7975984
Compare
|
Bitrise build failed due to the following error
|
Seems like a BR issue, a quick re-run should fix this 🤞🏼 |
This fixes #11702 which is a regression in the
syncClientsThenTabsfunction which is triggered by clicking the "Sync Now" button on the Remote Tabs Panel.