Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1881676 - Unconditionally set the "Enabled" label on the toggle switch #6022

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Mar 14, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1881676

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 14, 2024
@willdurand willdurand requested a review from Amejia481 March 14, 2024 12:58
@Amejia481 Amejia481 added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Mar 14, 2024
@willdurand willdurand added the 🛬 needs landing PRs that are ready to land label Mar 14, 2024
@rvandermeulen rvandermeulen merged commit 8a69a9a into main Mar 14, 2024
185 of 187 checks passed
@rvandermeulen rvandermeulen deleted the enabled-label branch March 14, 2024 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants