Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1885288 - Add logs to FeatureSettingsHelperDelegate #6018

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

AndiAJ
Copy link
Contributor

@AndiAJ AndiAJ commented Mar 14, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1885288

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Mar 14, 2024
@AndiAJ AndiAJ marked this pull request as ready for review March 14, 2024 10:34
@AndiAJ AndiAJ self-assigned this Mar 14, 2024
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Mar 14, 2024
@AndiAJ AndiAJ assigned sv-ohorvath and jjSDET and unassigned sv-ohorvath and jjSDET Mar 14, 2024
@AndiAJ AndiAJ requested review from sv-ohorvath and jjSDET March 14, 2024 10:35
@sv-ohorvath sv-ohorvath added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Mar 14, 2024
@AndiAJ AndiAJ added the 🛬 needs landing PRs that are ready to land label Mar 14, 2024
@mergify mergify bot merged commit 8a49590 into mozilla-mobile:main Mar 14, 2024
23 checks passed
@AndiAJ AndiAJ deleted the featureSettingsHelperDelegateLogs branch March 14, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants