Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1882404 - Expose granted permissions on AC. #5793

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Feb 27, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1882404

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Feb 27, 2024
@Amejia481 Amejia481 requested a review from willdurand February 27, 2024 22:02
@Amejia481 Amejia481 added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 27, 2024
Copy link
Contributor

mergify bot commented Feb 27, 2024

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

@github-actions github-actions bot removed the work in progress Not ready to land yet. Work in progress (WIP). label Feb 28, 2024
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable, thanks

@willdurand willdurand added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Mar 1, 2024
@Amejia481 Amejia481 force-pushed the bug-1882404 branch 2 times, most recently from 976c4c8 to 7ddc20e Compare March 14, 2024 17:39
@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Mar 14, 2024
@mergify mergify bot merged commit 112c65b into mozilla-mobile:main Mar 14, 2024
111 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants