Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixup breaking changes from AppServices upgrade to 93.0.1 #24669

Closed

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Apr 7, 2022

Fixes changes caused by mozilla-mobile/android-components#11972

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@jhugman jhugman requested review from a team as code owners April 7, 2022 22:46
@jhugman jhugman force-pushed the jhugman/fix-breaking-changes-for-app-services-93.0.0 branch from c727f61 to faf0ca4 Compare April 7, 2022 23:08
@bendk
Copy link
Contributor

bendk commented Apr 13, 2022

I'm seeing this error when trying to build:

e: /home/bdk/fenix/app/build/generated/source/nimbus/debug/kotlin/org/mozilla/fenix/nimbus/FxNimbus.kt: (126, 46): Property delegate must have a 'getValue(DefaultBrowserMessage, KProperty<*>)' method. None of the following functions is suitable: 
public inline operator fun <T> Lazy<{Comparable<{MessageSurfaceId & String}>? & java.io.Serializable?}?>.getValue(thisRef: Any?, property: KProperty<*>): {Comparable<{MessageSurfaceId & String}>? & java.io.Serializable?}? defined in kotlin

Any ideas how to fix it?

@jhugman
Copy link
Contributor Author

jhugman commented Apr 19, 2022

I think you need to land pr#11972 and pr#11799. then wait overnight for an ac release
that will break the build for fenix, and then you land fenix#24669 to fix that.

/cc @Amejia481 would you mind helping navigate this upgrade/update cycle?

@Amejia481
Copy link
Contributor

upgrade

We have around 2 week for the next beta cut, it will be on May 3rd, I think we have time to figure out any issue earlier.

@jhugman jhugman changed the title Fixup breaking changes from AppServices upgrade to 93.0.0 Fixup breaking changes from AppServices upgrade to 93.0.1 Apr 20, 2022
@jhugman jhugman force-pushed the jhugman/fix-breaking-changes-for-app-services-93.0.0 branch from faf0ca4 to d2f6aa2 Compare April 20, 2022 19:26
@gabrielluong
Copy link
Member

Closing this since the change was done in #24904.

@rvandermeulen rvandermeulen deleted the jhugman/fix-breaking-changes-for-app-services-93.0.0 branch August 2, 2022 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants