Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Close #13336: Open bookmark in current tab if browsing mode is not private or previous fragment is not home #23946

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Feb 23, 2022

Fixes #13336

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

…mode is not private or previous fragment is not home
@rocketsroger rocketsroger added the needs:review PRs that need to be reviewed label Feb 23, 2022
@rocketsroger rocketsroger requested review from a team as code owners February 23, 2022 21:12
Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since your commit msg says "Close", can you make sure to reopen the ticket and set qa:needed when this lands.

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Feb 23, 2022
@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Feb 23, 2022
@mergify mergify bot merged commit 77c2ad9 into mozilla-mobile:main Feb 24, 2022
@rocketsroger rocketsroger deleted the FB_13336 branch February 24, 2022 02:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks should open in existing tab when navigating to bookmarks UI from a page
2 participants