Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Update Application services to 93.1.0 #12120

Merged
merged 5 commits into from
May 9, 2022
Merged

Update Application services to 93.1.0 #12120

merged 5 commits into from
May 9, 2022

Conversation

tarikeshaq
Copy link
Contributor

This is #12044 with an extra commit to bump the version to fix #12099

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@tarikeshaq tarikeshaq requested review from jonalmeida and a team as code owners May 6, 2022 20:04
@tarikeshaq
Copy link
Contributor Author

Also cherry-picked #12094 😄

@tarikeshaq
Copy link
Contributor Author

tarikeshaq commented May 6, 2022 •
edited
Loading

mozilla-mobile/fenix#24904 is still the PR we need for fenix, the bump from 93.0.1 to 93.1.0 shouldn't have extra breaking changes 😄

jonalmeida
jonalmeida approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonalmeida jonalmeida added the do not land PRs that requires coordination before landing label May 6, 2022
@jonalmeida
Copy link
Contributor

Let's land on Monday.

@mergify
Copy link
Contributor

mergify bot commented May 9, 2022

This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? 🙏

@jonalmeida jonalmeida added 🛬 needs landing (squash) PRs that are ready to land (squashed) and removed do not land PRs that requires coordination before landing labels May 9, 2022
@jonalmeida
Copy link
Contributor

Landing now.

@jonalmeida jonalmeida mentioned this pull request May 9, 2022
Closed
@mergify mergify bot merged commit c820eda into mozilla-mobile:main May 9, 2022
@jonalmeida
Copy link
Contributor

Manually triggered an AC release to use it with Fenix: https://firefox-ci-tc.services.mozilla.com/tasks/groups/dt2uesSUQ_WpOxVbSV-Kaw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonalmeida jonalmeida jonalmeida approved these changes

Assignees
No one assigned
Labels
🛬 needs landing (squash) PRs that are ready to land (squashed)
Projects
None yet
Milestone
No milestone
4 participants
@tarikeshaq @jonalmeida @mhammond @jhugman