Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #10026: Make the CreditCard data class parcelable #10027

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

gabrielluong
Copy link
Member

Fixes #10026

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #10027 (e2f5635) into master (feef82f) will decrease coverage by 1.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10027      +/-   ##
============================================
- Coverage     74.12%   72.24%   -1.89%     
+ Complexity     5835      564    -5271     
============================================
  Files           786       83     -703     
  Lines         29203     2731   -26472     
  Branches       4799      379    -4420     
============================================
- Hits          21648     1973   -19675     
+ Misses         5044      487    -4557     
+ Partials       2511      271    -2240     
Impacted Files Coverage Δ Complexity Δ
...nents/browser/state/reducer/WebExtensionReducer.kt
...nts/lib/publicsuffixlist/PublicSuffixListLoader.kt
.../components/browser/state/reducer/SystemReducer.kt
.../components/feature/downloads/DownloadsUseCases.kt
...omponents/concept/menu/candidate/ContainerStyle.kt
...onents/feature/prompts/dialog/BasicColorAdapter.kt
...nents/concept/menu/candidate/SmallMenuCandidate.kt
...nts/browser/menu2/adapter/icons/MenuIconAdapter.kt
...ponents/browser/state/reducer/LastAccessReducer.kt
...mponents/feature/downloads/DownloadNotification.kt
... and 693 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feef82f...e2f5635. Read the comment docs.

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable change needed for Fenix.
r+.

@gabrielluong gabrielluong added the 🛬 needs landing PRs that are ready to land label Apr 8, 2021
@mergify mergify bot merged commit 04752b2 into mozilla-mobile:master Apr 8, 2021
@gabrielluong gabrielluong deleted the 10026 branch April 8, 2021 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the CreditCard data class parcelable
2 participants