Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add ability to filter tabs to TabsUseCases.restore #9323

Closed
csadilek opened this issue Jan 5, 2021 · 1 comment
Closed

Add ability to filter tabs to TabsUseCases.restore #9323

csadilek opened this issue Jan 5, 2021 · 1 comment
Assignees
@pocmo @csadilek
Labels
🌟 feature New functionality and improvements <tabs> Components: browser-tabstray, feature-tabs
Milestone
71.0.0 🐈

Comments

@csadilek
Copy link
Contributor

csadilek commented Jan 5, 2021 •
edited by data-sync-user
Loading

This is to replace the following logic in Fenix which deletes tabs older than configured:
https://github.com/mozilla-mobile/fenix/blob/743ba6918f7df5bfa3cb966bb9705ea6f1dfbb99/app/src/main/java/org/mozilla/fenix/FenixApplication.kt#L179

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🌟 feature New functionality and improvements <tabs> Components: browser-tabstray, feature-tabs labels Jan 5, 2021
@csadilek csadilek mentioned this issue Jan 5, 2021
Merged
@csadilek
Copy link
Contributor Author

csadilek commented Jan 5, 2021

We currently restore all tabs and then delete the affected (timed out) tabs after. The goal here is to have TabsUseCases.restore take care of this by passing a parameter. This will also make sure that tabs cleanup has happened when the RestoreCompleteAction is dispatched.

@csadilek csadilek changed the title Add ability to filter tabs to restore use case Add ability to filter tabs to TabsUseCases.restore Jan 5, 2021
csadilek added a commit to csadilek/android-components that referenced this issue Jan 6, 2021
@csadilek
Closes mozilla-mobile#9323: Add ability to filter tabs to TabsUseCase…
b517f30 
…s.restore
csadilek added a commit to csadilek/android-components that referenced this issue Jan 6, 2021
@csadilek
Closes mozilla-mobile#9323: Add ability to filter tabs to TabsUseCase…
c22e01c 
…s.restore
csadilek added a commit to csadilek/android-components that referenced this issue Jan 6, 2021
@csadilek
Closes mozilla-mobile#9323: Add ability to filter tabs to TabsUseCase…
fa31658 
…s.restore
csadilek added a commit to csadilek/android-components that referenced this issue Jan 6, 2021
@csadilek
Closes mozilla-mobile#9323: Add ability to filter tabs to TabsUseCase…
bc38a73 
…s.restore
@csadilek csadilek added this to the 71.0.0 milestone Jan 7, 2021
@mergify mergify bot closed this as completed in 787e27a Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@csadilek csadilek

Labels
🌟 feature New functionality and improvements <tabs> Components: browser-tabstray, feature-tabs
Projects
None yet
Milestone
71.0.0 🐈
Development

No branches or pull requests
2 participants
@pocmo @csadilek