Unsupported URI scheme

[pocmo]

java.lang.IllegalArgumentException: Unsupported URI scheme
    at org.mozilla.geckoview.GeckoWebExecutor.fetch(GeckoWebExecutor.java:12)
    at mozilla.components.browser.engine.gecko.fetch.GeckoViewFetchClient.fetch(GeckoViewFetchClient.kt:45)
    at mozilla.components.browser.icons.loader.HttpIconLoader.load(HttpIconLoader.kt:13)
    at mozilla.components.browser.icons.BrowserIcons.access$loadIconInternal(BrowserIcons.kt:13)
    at mozilla.components.browser.icons.BrowserIcons$loadIcon$1.invokeSuspend(BrowserIcons.kt:3)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:21)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
    at java.lang.Thread.run(Thread.java:818)

Looks like we should check the icon URLs first.

┆Issue is synchronized with this Jira Task

[pocmo]

https://sentry.prod.mozaws.net/share/issue/142e1c8f44f342b8a2512b72676807cb/

[Amejia481]

I think we already have a check, maybe the condition is not getting met

android-components/components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt

Line 43 in facd604

if (request.isDataUri()) {

[pocmo]

I guess there can be literally anything://hello.world in the markup and we'd pass that to GeckoView.

[Amejia481]

👍

[Amejia481]

@pocmo I'm bit confused as we are validating that the scheme should http or https on shouldDownload

Source

    private fun shouldDownload(resource: IconRequest.Resource): Boolean {
        return resource.url.toUri().isHttpOrHttps && !failureCache.hasFailedRecently(resource.url)
    }