This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Thumbnail changes update the tabs tray too often #7313
Labels
🐞 bug
Something isn't working
performance
Performance related issues
<tabs>
Components: browser-tabstray, feature-tabs
<thumbnails>
Components: browser-thumbnails
Milestone
Comments
jonalmeida
added
🐞 bug
Something isn't working
<tabs>
Components: browser-tabstray, feature-tabs
<thumbnails>
Components: browser-thumbnails
labels
Jun 9, 2020
I verified that removing the In mozilla-mobile/fenix#11185 (comment), I mentioned we should try to use the
What changes though is the surface area of this API for the consumer to load the thumbnails where ever the caller needs. More concretely, the |
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
We were seeing odd bugs and performance issues from trying to map the disk cache into the TabsTrayPresenter. A better solution, would be to load the thumbnails straight from the cache, and incremental updates via the store.
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
We were seeing odd bugs and performance issues from trying to map the disk cache into the TabsTrayPresenter. A better solution, would be to load the thumbnails straight from the cache, and incremental updates via the store.
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
4 tasks
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
We were seeing odd bugs and performance issues from trying to map the disk cache into the TabsTrayPresenter. A better solution, would be to load the thumbnails straight from the cache, and incremental updates via the store.
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
We were seeing odd bugs and performance issues from trying to map the disk cache into the TabsTrayPresenter. A better solution, would be to load the thumbnails straight from the cache, and incremental updates via the store.
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Jun 12, 2020
bors bot
pushed a commit
that referenced
this issue
Jun 12, 2020
7356: Issue #7313: Use ThumbnailLoader for the TabViewHolder r=gabrielluong,boek a=jonalmeida Instead of trying to inline the thumbnail images from disk into the TabsTrayPresenter, we can load them from the `ThumbnailStorage` via the `ThumbnailLoader` and rely on the `TabsTrayPresenter` to consume new thumbnail updates only from the store. This fixes some perf issues, inconsistencies, and duplicate updates to the tabs tray. Co-authored-by: Jonathan Almeida <[email protected]>
This was referenced Jun 16, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🐞 bug
Something isn't working
performance
Performance related issues
<tabs>
Components: browser-tabstray, feature-tabs
<thumbnails>
Components: browser-thumbnails
When we update the tabs tray, we use the
generationId
from the bitmap to identify if the thumbnails have changed. It turns out that these are not stable (probably because we're compressing the images so the ID changes).We need a better way to avoid the whole tray from updating when we have a thumbnail update.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: