This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Properly catch PlacesException$OperationInterrupted #12569
Closed
Mugurell opened this issue
Jul 29, 2022
· 1 comment
· Fixed by #12570 or nathanmkaya/android-components#362
Closed
Properly catch PlacesException$OperationInterrupted #12569
Mugurell opened this issue
Jul 29, 2022
· 1 comment
· Fixed by #12570 or nathanmkaya/android-components#362
Milestone
Comments
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Jul 29, 2022
…rrupted exceptions This will catch OperationInterrupted exceptions from the interrupted operation.
4 tasks
mergify bot
pushed a commit
that referenced
this issue
Jul 29, 2022
…ions This will catch OperationInterrupted exceptions from the interrupted operation.
mergify bot
pushed a commit
that referenced
this issue
Jul 29, 2022
…ions This will catch OperationInterrupted exceptions from the interrupted operation. (cherry picked from commit 8378cc7)
Verifying in Sentry we see that:
So looks like the issues was indeed resolved. |
mergify bot
pushed a commit
that referenced
this issue
Aug 2, 2022
…ions This will catch OperationInterrupted exceptions from the interrupted operation. (cherry picked from commit 8378cc7)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There's a recent spike in handled exceptions reports for
PlacesException$OperationInterrupted
following #12469It was expected that this would happen but while the current approach would try to catch the exception as stemming from the
interrupt
call upon more investigation it seems like the actually interrupted operation will throw and only if the query was in progress, and in this scenario the exception is caught and reported because it was unexpected.As a solution the try catch blocks should be combined with the
handlePlacesException
alson expecting thePlacesException$OperationInterrupted
exception and not reporting it to the crash services.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: