This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Pocket sponsored stories pacing and rotation #12184
Labels
<pocket>
Component: Service-pocket
Comments
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 18, 2022
…red Pocket stories Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 18, 2022
…red Pocket stories Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
Mugurell
changed the title
Pocket sponsored stories rotation
Pocket sponsored stories pacing and rotation
May 18, 2022
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 24, 2022
…red Pocket stories Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 24, 2022
… PocketStoriesService This was a leftover from when migrating to use a GlobalDependencyProvider.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 24, 2022
…red Pocket stories Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 24, 2022
… PocketStoriesService This was a leftover from when migrating to use a GlobalDependencyProvider.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 25, 2022
…red Pocket stories Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 25, 2022
… PocketStoriesService This was a leftover from when migrating to use a GlobalDependencyProvider.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
May 25, 2022
…le is deleted This also allows to easily start a "new" Worker to download stories again when `startPeriodicStoriesRefresh` whereas we'd just enqueue the existing one which may be set to only refresh the stories after a few hours still.
mergify bot
pushed a commit
that referenced
this issue
May 26, 2022
…ries Stories can be paced and rotated based on the properties received in the endpoint response. Since rotating involves a limit of impressions in a certain period I've added a new table for keeping only this timestamps while the effective limits will be held in the sponsored stories table. With very little time between this and the previous patch which added support for sponsored stories I've skipped created a new database version and sticked to using version 2 again to ensure a smoother migration when this feature gets to the users. Possibly because of the foreignKey addition the migration could not be tested in the JVM (because of sqlite exceptions coming from robolectric) and so I switched testing this to a real device.
mergify bot
pushed a commit
that referenced
this issue
May 26, 2022
…Service This was a leftover from when migrating to use a GlobalDependencyProvider.
mergify bot
pushed a commit
that referenced
this issue
May 26, 2022
This also allows to easily start a "new" Worker to download stories again when `startPeriodicStoriesRefresh` whereas we'd just enqueue the existing one which may be set to only refresh the stories after a few hours still.
Path was merged. Changes to be later verified on Fenix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: