Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix MigrationTestHelper constructor deprecation in new room versions #11765

Closed
Mugurell opened this issue Feb 23, 2022 · 3 comments
Closed

Fix MigrationTestHelper constructor deprecation in new room versions #11765

Mugurell opened this issue Feb 23, 2022 · 3 comments

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 23, 2022 •
edited by data-sync-user
Loading

After #11754 room will be updated to version 2.4.1 which will have 2 of the MigrationTestHelper constructors deprecated, includint the one we use in LoginExceptionStorageTest - https://developer.android.com/reference/androidx/room/testing/MigrationTestHelper.

For now this deprecation doesn't pose an immediate problem as according to the official documentation they would only be an issue in the cases of tests involving AutoMigration, something that we don't use.

┆Issue is synchronized with this Jira Task
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 23, 2022
@Mugurell
For mozilla-mobile#11753 - Update compose to 1.1.0 and Kotlin to 1.6.10
5aa536a 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in mozilla-mobile#11765.

activity_compose was also update to the latest stable version to ensure a
better match with the latest stable version for compose.
@Mugurell Mugurell mentioned this issue Feb 23, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 23, 2022
@Mugurell
For mozilla-mobile#11753 - Update compose to 1.1.0 and Kotlin to 1.6.10
0d11f7a 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in mozilla-mobile#11765.

activity_compose was also update to the latest stable version to ensure a
better match with the latest stable version for compose.
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 23, 2022
@Mugurell
For mozilla-mobile#11753 - Update compose to 1.1.0 and Kotlin to 1.6.10
b2b1bc8 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in mozilla-mobile#11765.

activity_compose was also update to the latest stable version to ensure a
better match with the latest stable version for compose.
mergify bot pushed a commit that referenced this issue Feb 24, 2022
@Mugurell @mergify
For #11753 - Update compose to 1.1.0 and Kotlin to 1.6.10
e9cbe11 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in #11765.

activity_compose was also update to the latest stable version to ensure a
better match with the latest stable version for compose.
@gouri-panda
Copy link
Contributor

@Mugurell I would like to work on this issue.

@Mugurell
Copy link
Contributor Author

@gouri-panda This already has a patch availabe. It was in fact merged but then backed out because of other related issues.
We'll work on re-landing that original patch soon.

Mugurell added a commit to Mugurell/android-components that referenced this issue Apr 13, 2022
@Mugurell
For mozilla-mobile#11753 - Update compose to 1.1.1 and Kotlin to 1.6.20
6ab3f5c 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in mozilla-mobile#11765.

`activity_compose` was also update to the latest stable version to ensure a
better match with the latest stable version for compose.
@Mugurell Mugurell mentioned this issue Apr 13, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/android-components that referenced this issue Apr 14, 2022
@Mugurell
For mozilla-mobile#11753 - Update compose to 1.1.1 and Kotlin to 1.6.10
5dce7a1 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in mozilla-mobile#11765.

`activity_compose` was also update to the latest stable version to ensure a
better match with the latest stable version for compose.

Used 1.6.10 for Kotlin although 1.6.20 is available to prevent any issues with
Compose 1.1.1 reported as an error at compile time:
"e: This version (1.1.1) of the Compose Compiler requires Kotlin version 1.6.10
but you appear to be using Kotlin version 1.6.20 which is not known to be
compatible.  Please fix your configuration (or
`suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!)."
mergify bot pushed a commit that referenced this issue Apr 18, 2022
@Mugurell @mergify
For #11753 - Update compose to 1.1.1 and Kotlin to 1.6.10
ac93f1f 
This also required updating room to >= 2.4.0.
This new version adds a deprecation of the `MigrationTestHelper` api used in
`LoginExceptionStorageTest` that is to be later fixed in #11765.

`activity_compose` was also update to the latest stable version to ensure a
better match with the latest stable version for compose.

Used 1.6.10 for Kotlin although 1.6.20 is available to prevent any issues with
Compose 1.1.1 reported as an error at compile time:
"e: This version (1.1.1) of the Compose Compiler requires Kotlin version 1.6.10
but you appear to be using Kotlin version 1.6.20 which is not known to be
compatible.  Please fix your configuration (or
`suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!)."
@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1794859

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csadilek @Mugurell @gouri-panda