Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Replace clearColorFilter with setColorFilter for security icon #11545

Closed
ionutbedregeanu opened this issue Jan 14, 2022 · 0 comments
Closed

Replace clearColorFilter with setColorFilter for security icon #11545

ionutbedregeanu opened this issue Jan 14, 2022 · 0 comments
Assignees
@ionutbedregeanu

Comments

@ionutbedregeanu
Copy link

ionutbedregeanu commented Jan 14, 2022 •
edited by data-sync-user
Loading

Trying to fix mozilla-mobile/focus-android#6022 I noticed that clearColorFilter method doesn't work properly in Api 21, 22 and the default color filter is kept
Even if I invalidate the view after clearColorFilter the filter is not removed, so to fix the bug we need to use setColorFilter(Color.Transparent)

┆Issue is synchronized with this Jira Task
@ionutbedregeanu ionutbedregeanu self-assigned this Jan 14, 2022
ionutbedregeanu pushed a commit to ionutbedregeanu/android-components that referenced this issue Jan 14, 2022
For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…
61a8ac7 
…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent
ionutbedregeanu pushed a commit to ionutbedregeanu/android-components that referenced this issue Jan 14, 2022
For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…
d42bd3a 
…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent
@ionutbedregeanu ionutbedregeanu mentioned this issue Jan 14, 2022
Merged
4 tasks
@ionutbedregeanu ionutbedregeanu changed the title Clear color filter doesn't work on Api 21, 22 Replace clearColorFilter with setColorFilter for security icon Jan 14, 2022
ionutbedregeanu pushed a commit to ionutbedregeanu/android-components that referenced this issue Jan 19, 2022
For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…
5d4aa39 
…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent when the API version is lower than 23
ionutbedregeanu pushed a commit to ionutbedregeanu/android-components that referenced this issue Jan 19, 2022
For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…
4406c48 
…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent when the API version is lower than 23
ionutbedregeanu pushed a commit to ionutbedregeanu/android-components that referenced this issue Jan 20, 2022
For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…
b86cdc9 
…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent when the API version is lower than 23
mergify bot pushed a commit that referenced this issue Jan 21, 2022
@mergify
For #11545 - Replace clearColorFilter with setColorFilter for securit…
b55a7d8 
…y icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent when the API version is lower than 23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ionutbedregeanu ionutbedregeanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonalmeida @ionutbedregeanu