Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Improve immersive mode restore #11374

Closed
Mugurell opened this issue Dec 8, 2021 · 1 comment
Closed

Improve immersive mode restore #11374

Mugurell opened this issue Dec 8, 2021 · 1 comment
Assignees
@Mugurell

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Dec 8, 2021 •
edited by data-sync-user
Loading

Saw in mozilla-mobile/fenix#20240 that on some devices interacting with other Windows - like of Dialogs or of the keyboard will break the Activity from the immersive mode without it going back to immersive after the interaction with other widgets completed.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Dec 8, 2021
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 8, 2021
@Mugurell
For mozilla-mobile#11374 - New insets listener to restore immersive mode
b290ee2
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 8, 2021
@Mugurell
For mozilla-mobile#11374 - New insets listener to restore immersive mode
5c5d12c
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 8, 2021
@Mugurell
For mozilla-mobile#11374 - Handle focus changes in our own private li…
f771c84 
…stener

Previously we'd allow a listener being passed in and we'd hope it will
correctly handle restoring immersive mode.
Now we are handling focus changes and restoring immersive mode on ourselves
also allowing for a simpler public API.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jan 6, 2022
@Mugurell
For mozilla-mobile#11374 - New insets listener to restore immersive mode
e6ceff4
Mugurell added a commit to Mugurell/android-components that referenced this issue Jan 6, 2022
@Mugurell
For mozilla-mobile#11374 - Handle focus changes in our own private li…
563780f 
…stener

Previously we'd allow a listener being passed in and we'd hope it will
correctly handle restoring immersive mode.
Now we are handling focus changes and restoring immersive mode on ourselves
also allowing for a simpler public API.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jan 6, 2022
@Mugurell
For mozilla-mobile#11374 - Handle focus changes in our own private li…
6a54655 
…stener

Previously we'd allow a listener being passed in and we'd hope it will
correctly handle restoring immersive mode.
Now we are handling focus changes and restoring immersive mode on ourselves
also allowing for a simpler public API.
mergify bot pushed a commit that referenced this issue Jan 6, 2022
@Mugurell @mergify
For #11374 - New insets listener to restore immersive mode
5802ffc
mergify bot pushed a commit that referenced this issue Jan 6, 2022
@Mugurell @mergify
For #11374 - Handle focus changes in our own private listener
3872430 
Previously we'd allow a listener being passed in and we'd hope it will
correctly handle restoring immersive mode.
Now we are handling focus changes and restoring immersive mode on ourselves
also allowing for a simpler public API.
@Mugurell Mugurell mentioned this issue Jan 12, 2022
Closed
@Mugurell
Copy link
Contributor Author

Fix verified in Fenix - mozilla-mobile/fenix#20240 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mugurell