Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add support for select credit card prompt #10205

Closed
gabrielluong opened this issue May 3, 2021 · 0 comments · Fixed by #10213
Closed

Add support for select credit card prompt #10205

gabrielluong opened this issue May 3, 2021 · 0 comments · Fixed by #10213
Assignees
@gabrielluong
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E2 Estimation points: 2
Milestone
90.0.0 🌳

Comments

@gabrielluong
Copy link
Member

gabrielluong commented May 3, 2021 •
edited by data-sync-user
Loading

This issue is to add a SelectCreditCardPrompt to PromptRequest to handle GV prompts for autocompleting a credit card form.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this May 3, 2021
@gabrielluong gabrielluong added cc-autofill <autofill> Credit Card, Addresses and Logins autofill functionality E2 Estimation points: 2 labels May 3, 2021
@gabrielluong gabrielluong changed the title Add support for select credit card dialogs Add support for select credit card prompt May 4, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 4, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
b5121d1 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
@gabrielluong gabrielluong mentioned this issue May 4, 2021
Merged
4 tasks
@gabrielluong gabrielluong added this to the 90.0.0 🌳 milestone May 4, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 4, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
f7ea4e3 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
ffd1db3 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
bce8174 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
4605d37 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
d4d37de 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
ef7864e 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
db64440 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
db82d51 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
b33ca44 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 7, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
95219e0 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 9, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
9316743 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCardPrompt` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 10, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
a27dd0f 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCard` in `PromptRequest`
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 11, 2021
@gabrielluong
Issue mozilla-mobile#10205: Add support for select credit card prompt
bf725a2 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCard` in `PromptRequest`
@mergify mergify bot closed this as completed in #10213 May 11, 2021
mergify bot pushed a commit that referenced this issue May 11, 2021
@gabrielluong @mergify
Issue #10205: Add support for select credit card prompt
b185faa 
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate`
- Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's
`Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage`
since that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
- Adds a new `SelectCreditCard` in `PromptRequest`
@gabrielluong gabrielluong mentioned this issue Apr 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E2 Estimation points: 2
Projects
None yet
Milestone
90.0.0 🌳
Development

Successfully merging a pull request may close this issue.

Issue #10205: Add support for select credit card prompt gabrielluong/android-components
1 participant
@gabrielluong