Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old servers.Malmö ids #489

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mcleinman
Copy link
Contributor

@mcleinman mcleinman commented Nov 13, 2024

This is part of the work being done for VPN-6649 ticket. More details are available on mozilla-mobile/mozilla-vpn-client#10029.

This work consists of 4 PRs, to be merged in order:

  1. An earlier PR on this repo - copied all existing translations of Malmö from servers.Malmö to servers.Malm.
  2. A fixit PR on this repo: https://github.com/mozilla-l10n/mozilla-vpn-client-l10n/pull/490/files
  3. On the client repo: Adjusting the script when creating IDs for server translations (VPN-6649: fix translations for cities with special characters mozilla-mobile/mozilla-vpn-client#10029)
  4. This PR: remove all the legacy servers.Malmö translations strings.

@mcleinman mcleinman requested a review from flodolo as a code owner November 13, 2024 19:29
@mcleinman mcleinman marked this pull request as draft November 13, 2024 19:29
@flodolo
Copy link
Contributor

flodolo commented Nov 13, 2024

This will require a rebase at the end.

@mcleinman mcleinman marked this pull request as ready for review November 15, 2024 00:46
@mcleinman
Copy link
Contributor Author

The other PRs in the sequence have been merged, and I've rebased this branch. This should be ready for review.

@flodolo flodolo merged commit 48575cb into mozilla-l10n:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants