basti/fix handleBrigeResponse #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
strseb
commented
Dec 16, 2024
strseb
commented
- Make sure also initial values are immutable
- Fix handleBridgeResponse
strseb
commented
Dec 16, 2024
| // We can only get 2 types of messages right now: client-down/up | ||
| if ( | ||
| (response.status && response.status === "vpn-client-down") || | ||
| (response.error && response.error === "vpn-client-down") | ||
| ) { | ||
| // If we have been considering the client open, it is now closed. | ||
| if (state.alive) { | ||
| state = new StateVPNClosed(); |
There was a problem hiding this comment.
This is the function arg, not the actual property. sooo nothing was set.
strseb
commented
Dec 16, 2024
Comment on lines
194
to
203
| test("handles vpn-client-down when client is alive", async () => { | ||
| const state = { alive: true, installed: true }; | ||
|
|
||
| const state = property({ alive: true, installed: true }); | ||
| await vpnController.handleBridgeResponse( | ||
| { status: "vpn-client-down" }, | ||
| state | ||
| ); | ||
|
|
||
| expect(vpnController.state.value.installed).toBe(true); | ||
| expect(vpnController.state.value.alive).toBe(false); | ||
| expect(state.value.installed).toBe(true); | ||
| expect(state.value.alive).toBe(false); | ||
| }); |
There was a problem hiding this comment.
Now how did the unit test not catch that, welll :
expect(new VpnController().state.value.alive).toBe(false);
expect(new VpnController().state.value.alive).toBe(false);
I should have made this function static from the beginning >_<
lesleyjanenorton
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.