Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagically hide butter bars #150

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Automagically hide butter bars #150

merged 3 commits into from
Dec 14, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Dec 13, 2024

This is a follow up to #146 because I overlooked the following acceptance criteria:
The warning disappears on its own when all proxy-setting extensions are inactive / removed.

Ergo, this PR:

  • Automagically hides butter bar alerts when conflicting extensions are disabled and removed

    • Does not add these alerts to the list of dismissed alerts so that they are eligible to be shown again, should the same conflict or another conflict re-materialize
  • Renames the fn exposed to the UI from removeAlert -> dismissAlert

    • Dismissed alerts are added to the dismissed alert list and are not shown again, regardless of the status of the conflict.
  • Updates and adds tests

@lesleyjanenorton lesleyjanenorton merged commit 40a3036 into main Dec 14, 2024
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the butter-bar-continued branch December 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants