Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Add static parameters to matchers #354

Closed
ianb opened this issue Oct 2, 2019 · 0 comments · Fixed by #361
Closed

Add static parameters to matchers #354

ianb opened this issue Oct 2, 2019 · 0 comments · Fixed by #361

Comments

@ianb
Copy link
Contributor

ianb commented Oct 2, 2019

Right now you can make matchers that have static strings and slots, but you can't tell which matcher matched the string. We should add parameters, maybe like play album [query] [type=album].

We should make sure these don't break the match prioritization. So instead of being slots they should be separate, e.g., context.params.type.

ianb added a commit that referenced this issue Oct 2, 2019
Fix #321, add skip/next for Spotify and Youtube (and previous for Spotify)
Fix #354, add static parameters to matches
@ianb ianb closed this as completed in #361 Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant