Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Previous session displayed when trying to do a blank search #193

Closed
alexandra-martin opened this issue Sep 5, 2019 · 3 comments
Closed
Assignees
Labels
bug Something isn't working Verified Fix was validated by QA
Milestone

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic permissions are enabled.

STR:

  1. Click on the mic icon from the browser toolbar.
  2. Write a command, e.g. "search fox", press "Enter" and wait for the result to appear in the "Doorhanger".
  3. Click the "Back" button.
  4. Delete the previous "search fox" command.
  5. Press "Enter".

Expected result:

The "Doorhanger" has a notification that no match is found.

Actual result:

The "Doorhanger" displays the previous search result.

Notes:

Reproduced on Mac 10.14.6 with Firefox Nightly 71.0a1 (64-bit).
Reproduced also in the following circumstance, shown in the second gif:

  • after the result appears in the "Doorhanger", the "search fox" command title is deleted while in session, like in 192, the "Back" button is clicked, then "Enter" is pressed (blank search).

voice 17

voice 16

@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 5, 2019
@awallin
Copy link
Contributor

awallin commented Sep 5, 2019

Likely related to #170 and other back button issues.

@awallin awallin added this to the External beta milestone Sep 5, 2019
@ianb ianb self-assigned this Sep 13, 2019
@ianb ianb closed this as completed in 794066a Sep 16, 2019
@alexandra-martin
Copy link
Author

The bug is still reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

voice 38

@ianb ianb closed this as completed in c296f99 Sep 19, 2019
ianb added a commit that referenced this issue Sep 19, 2019
Fix #193, reload popup so text box contents aren't preserved
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

38

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Verified Fix was validated by QA
Projects
None yet
Development

No branches or pull requests

3 participants