Skip to content

Commit

Permalink
Merge pull request mozilla#8006 from timvandermeij/mozFillRule
Browse files Browse the repository at this point in the history
Remove usage of `mozFillRule`
  • Loading branch information
Snuffleupagus authored Jan 30, 2017
2 parents 414a813 + e7da1a2 commit 89e9d2f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 21 deletions.
16 changes: 2 additions & 14 deletions src/display/canvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -1229,13 +1229,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
}

if (this.pendingEOFill) {
if (ctx.mozFillRule !== undefined) {
ctx.mozFillRule = 'evenodd';
ctx.fill();
ctx.mozFillRule = 'nonzero';
} else {
ctx.fill('evenodd');
}
ctx.fill('evenodd');
this.pendingEOFill = false;
} else {
ctx.fill();
Expand Down Expand Up @@ -2273,13 +2267,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
var ctx = this.ctx;
if (this.pendingClip) {
if (this.pendingClip === EO_CLIP) {
if (ctx.mozFillRule !== undefined) {
ctx.mozFillRule = 'evenodd';
ctx.clip();
ctx.mozFillRule = 'nonzero';
} else {
ctx.clip('evenodd');
}
ctx.clip('evenodd');
} else {
ctx.clip();
}
Expand Down
8 changes: 1 addition & 7 deletions test/features/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,13 +372,7 @@ var tests = [
var ctx = canvas.getContext('2d');
ctx.rect(1, 1, 50, 50);
ctx.rect(5, 5, 41, 41);

if ('mozFillRule' in ctx) {
ctx.mozFillRule = 'evenodd';
ctx.fill();
} else {
ctx.fill('evenodd');
}
ctx.fill('evenodd');

var data = ctx.getImageData(0, 0, 50, 50).data;
var isEvenOddFill = data[20 * 4 + 20 * 200 + 3] == 0 &&
Expand Down

0 comments on commit 89e9d2f

Please sign in to comment.