Update aptos-core, use 0 as the reward percentage #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
requested review from
l-monninger,
andyjsbell and
0xmovses
as code owners
l-monninger
approved these changes
Jul 18, 2024
| @@ -58,7 +58,7 @@ impl Executor { | |||
| max_stake: 100_000_000_000_000, | |||
| recurring_lockup_duration_secs: EPOCH_DURATION_SECS * 2, | |||
| required_proposer_stake: 0, | |||
| rewards_apy_percentage: 10, | |||
| rewards_apy_percentage: 0, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units.After movementlabsxyz/aptos-core#45, the
rewards_apy_percentagefield in the genesis configuration is used to calculate the rewards without Movement-specific hacks, but this means it has to be set to 0 for our purposes.Changelog
rewards_apy_percentageparameter is set to 0 to represent the reality of not using rewards on Aptos blockchain level.Testing
Currently run tests should pass.