Dependency bump for diesel 2.2 and diesel-async 0.5 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
commented
Nov 12, 2024
Comment on lines
+155
to
+162
| parquet_gap_detection_batch_size: 50, | ||
| pb_channel_txn_chunk_size: 100_000, | ||
| per_table_chunk_sizes: Default::default(), | ||
| transaction_filter: Default::default(), | ||
| grpc_response_item_timeout_in_secs: 10, | ||
| transaction_filter: Default::default(), | ||
| deprecated_tables: Default::default(), | ||
| default_sleep_time_between_request: | ||
| IndexerGrpcProcessorConfig::default_sleep_time_between_request(), |
There was a problem hiding this comment.
Please check if the added default field values are sensible.
There was a problem hiding this comment.
Yes, these are sensible.
l-monninger
previously approved these changes
Nov 13, 2024
This pulls in a newer revision of aptos-indexer-processors, which requires adaptation in local_testnet CLI.
mzabaluev
force-pushed
the
mikhail/diesel-2.2
branch
from
efbd713 to
1e3d3db
Compare
|
I'm not familiar with the |
l-monninger
approved these changes
Nov 13, 2024
I have no idea, just bumped the versions and all seems to build like before. Perhaps the library that uses |
musitdev
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step to fixing https://github.com/movementlabsxyz/movement/security/dependabot/12
Requires movementlabsxyz/aptos-indexer-processors#5
Description
Bump diesel to 2.2 and diesel-async to 0.5
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
CI tests should pass
Key Areas to Review
This pulls in a newer revision of aptos-indexer-processors, which required adaptation in local_testnet CLI.