movement branch #115
Open
movement branch #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f3e0e5.
Use ? for terser, idiomatic code that can be cribbed for production.
Draft a test for FinalityView, checking that the latest_state_checkpoint_view extension method gets us the view into finalized state. StateView support in the mock is needed to complete the test.
In FinalityView::set_finalized_block_height, remove the outdated sanity check, add comments explaining why we can use the empty hash and no signatures specifically for Movement.
For set_finalized_block_height, retrieve ledger info from the corresponding epoch or use the latest.
Exercise the DbStateView instance returned from latest_state_checkpoint_view. No testing yet if the state matches expectations for the finalized version.
This reverts commit 1731cce.
Access to account state is convenient to test with.
`FinalityView`, a `DbReader` wrapper to represent a finalized state
…mentation Faucet Instrumentation
Pass LedgerInfoWithSignatures by reference like in other methods. Do not try to set epoch and version on the LedgerInfo in a way that does not work. Instead, it's expected to be correct for the latest pre-revert version.
All necessary information can be obtained from either the LedgerInfoWithSignatures, or the current database state.
Update both progress values in the ledger metadata schema in one batch.
…vert Make `LedgerInfo` the source of truth on revert
Rewrite the computation for rewards rate to avoid division by zero when the epoch duration exceeds one year.
…n-long-epochs fix: prevent zero divide on long epoch duration
…th side. Move unit tests pass, still working on E2E Move tests
…he expected bridge transfer ID
…for now to help reviewers make sense of everything
Native bridge: Modify param serialization to make bridge transfer IDs match on Move and Solidity sides in both L1 -> L2 and L2 -> L1 directions
Add Bridge Fee to Move Bridge Module
…ovementlabsxyz/aptos-core into andygolay/remove-initiate-hex-complete
…ve unit tests pass
…e-hex-complete Fix: remove hex conversion from initiator in complete bridge transfer, refactor to one module per file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist