Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset joint values in scene diff for execution #498

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Reset joint values in scene diff for execution #498

merged 2 commits into from
Oct 24, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 23, 2023

Implements solution 2 of #353 and should solve it

@sjahr sjahr requested review from rhaschke and JafarAbdi October 23, 2023 09:02
@sjahr sjahr changed the base branch from master to ros2 October 23, 2023 09:02
@sjahr sjahr mentioned this pull request Oct 23, 2023
Closed
@sjahr sjahr self-assigned this Oct 23, 2023
@sjahr sjahr linked an issue Oct 23, 2023 that may be closed by this pull request
Using ExecuteTaskSolutionCapability to execute a solution is overriding the joint state values #353
Closed
@sjahr sjahr closed this Oct 23, 2023
@sjahr sjahr reopened this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b25d2ba) 42.82% compared to head (71d9c3e) 42.80%.

❗ Current head 71d9c3e differs from pull request most recent head dd6f683. Consider uploading reports for the commit dd6f683 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             ros2     #498      +/-   ##
==========================================
- Coverage   42.82%   42.80%   -0.01%     
==========================================
  Files          82       82              
  Lines        7967     7970       +3     
==========================================
  Hits         3411     3411              
- Misses       4556     4559       +3
Files Coverage Δ
core/src/task.cpp 64.12% <0.00%> (-0.93%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MarqRazz
MarqRazz reviewed Oct 23, 2023
View reviewed changes
sjahr
sjahr commented Oct 23, 2023
View reviewed changes
MarqRazz
MarqRazz approved these changes Oct 23, 2023
View reviewed changes
Copy link

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sjahr

@sjahr sjahr merged commit fb02c7f into moveit:ros2 Oct 24, 2023
@sjahr sjahr mentioned this pull request Oct 27, 2023
Closed
rhaschke added a commit that referenced this pull request Nov 8, 2023
@rhaschke
fixup! Reset joint values in scene diff for execution (#498)
846e8f7
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Nov 8, 2023
@rhaschke
fixup! Reset joint values in scene diff for execution (moveit#498)
9d1a00d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

@MarqRazz MarqRazz MarqRazz approved these changes

@rhaschke rhaschke Awaiting requested review from rhaschke

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

Assignees

@sjahr sjahr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using ExecuteTaskSolutionCapability to execute a solution is overriding the joint state values
3 participants
@sjahr @sea-bass @MarqRazz