-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random pose generator stage (ros2) #497
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## ros2 #497 +/- ##
==========================================
- Coverage 42.82% 42.41% -0.40%
==========================================
Files 82 83 +1
Lines 7967 8043 +76
==========================================
Hits 3411 3411
- Misses 4556 4632 +76
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like having at least a few tests for this new functionality would be appropriate... besides that, nothing major on my end.
core/include/moveit/task_constructor/stages/generate_random_pose.h
Outdated
Show resolved
Hide resolved
core/include/moveit/task_constructor/stages/generate_random_pose.h
Outdated
Show resolved
Hide resolved
core/include/moveit/task_constructor/stages/generate_random_pose.h
Outdated
Show resolved
Hide resolved
core/include/moveit/task_constructor/stages/generate_random_pose.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Castro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy to see this is finally getting added in!
ROS 2 port of #166