Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random pose generator stage (ros2) #497

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 20, 2023

ROS 2 port of #166

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (b25d2ba) 42.82% compared to head (2ac263e) 42.41%.
Report is 1 commits behind head on ros2.

Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #497      +/-   ##
==========================================
- Coverage   42.82%   42.41%   -0.40%     
==========================================
  Files          82       83       +1     
  Lines        7967     8043      +76     
==========================================
  Hits         3411     3411              
- Misses       4556     4632      +76     
Files Coverage Δ
core/src/stages/generate_pose.cpp 0.00% <0.00%> (ø)
core/src/stages/generate_random_pose.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr requested a review from henningkayser October 23, 2023 14:49
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like having at least a few tests for this new functionality would be appropriate... besides that, nothing major on my end.

Co-authored-by: Sebastian Castro <[email protected]>
Copy link

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to see this is finally getting added in!

@sjahr sjahr requested review from MarqRazz and sea-bass October 24, 2023 09:05
@sjahr sjahr merged commit 8375e6e into moveit:ros2 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants