Skip to content

Commit

Permalink
Eexcuted add_two_ints_server in Node instead of ExecuteProcess.
Browse files Browse the repository at this point in the history
- ExecuteProcess runs two process which are sh and ros2_node,
  if there is no signal handler for SIGINT, SIGTERM etc. when sh is terminated,
  some process may continue to run without killing.
  • Loading branch information
CihatAltiparmak committed Aug 3, 2024
1 parent f46f58d commit ce7ad9f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions launch/scenario_basic_service_client_benchmark.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ def launch_setup(context, *args, **kwargs):
context.perform_substitution(LaunchConfiguration("sending_request_number"))
)

add_two_ints_server_node = ExecuteProcess(
cmd=[["ros2 run demo_nodes_cpp add_two_ints_server"]],
shell=True,
add_two_ints_server_node = Node(
name="add_two_ints_server",
package="demo_nodes_cpp",
executable="add_two_ints_server",
)

benchmark_main_node = Node(
Expand Down

0 comments on commit ce7ad9f

Please sign in to comment.