Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use venv in CI #916

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

stephanie-eng
Copy link
Contributor

Description

Fix this error:

 error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

This should make CI pass the "Install Python Dependencies" step.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to add a note to the htmlproofer.sh instructions that this needs to be run in a virtual environment. Otherwise, I think we should go for it and fix the actual build errors separately.

@stephanie-eng stephanie-eng requested a review from sea-bass July 11, 2024 01:20
@stephanie-eng
Copy link
Contributor Author

I updated a doc page and added in a comment. It looks like that doc page I updated has other issues (the htmlproofer script requires ruby to be installed, the requirements currently say Galactic), but those changes can be done in separate PRs - those issues are not particularly related to the virtual environment stuff.

@stephanie-eng stephanie-eng enabled auto-merge (squash) July 11, 2024 02:04
@stephanie-eng stephanie-eng merged commit 1709ece into moveit:main Jul 26, 2024
5 of 8 checks passed
@sea-bass sea-bass added the backport-humble This label signals Mergify to backport this PR to Humble label Nov 17, 2024
mergify bot pushed a commit that referenced this pull request Nov 17, 2024
* Use venv in CI

* Update htmlproofer instructions

* Add a comment about venv

* Reference which script "the script" means

* Format

(cherry picked from commit 1709ece)

# Conflicts:
#	.github/workflows/deploy.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label signals Mergify to backport this PR to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants