-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use venv in CI #916
Use venv in CI #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to add a note to the htmlproofer.sh
instructions that this needs to be run in a virtual environment. Otherwise, I think we should go for it and fix the actual build errors separately.
I updated a doc page and added in a comment. It looks like that doc page I updated has other issues (the htmlproofer script requires ruby to be installed, the requirements currently say Galactic), but those changes can be done in separate PRs - those issues are not particularly related to the virtual environment stuff. |
* Use venv in CI * Update htmlproofer instructions * Add a comment about venv * Reference which script "the script" means * Format (cherry picked from commit 1709ece) # Conflicts: # .github/workflows/deploy.yml
Description
Fix this error:
This should make CI pass the "Install Python Dependencies" step.