Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recommendation for Cyclone due to FastDDS issues #799

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Remove recommendation for Cyclone due to FastDDS issues #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4281279
Remove recommendation for Cyclone due to FastDDS issues
henningkayser Oct 25, 2023
d62c680
Remove cyclone config from Dockerfile
henningkayser Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ RUN --mount=type=cache,target=/root/.ccache/ \
. "/opt/ros/${ROS_DISTRO}/setup.sh" &&\
. "install/setup.sh" &&\
sudo apt update && rosdep install -r --from-paths src --ignore-src --rosdistro $ROS_DISTRO -y && \
sudo apt install -y ros-${ROS_DISTRO}-rmw-cyclonedds-cpp && \
colcon build \
--cmake-args -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
Expand All @@ -63,6 +62,5 @@ RUN --mount=type=cache,target=/root/.ccache/ \
rm -rf /var/lib/apt/lists/* && \
# Update /ros_entrypoint.sh to source our new workspace
sed -i "s#/opt/ros/\$ROS_DISTRO/setup.bash#$ROS_UNDERLAY/install/setup.bash#g" /ros_entrypoint.sh && \
echo "export RMW_IMPLEMENTATION=rmw_cyclonedds_cpp" >> /root/.bashrc && \
echo "source /opt/ros/${ROS_DISTRO}/setup.bash" >> /root/.bashrc && \
echo "source /root/ws_moveit/install/setup.bash" >> /root/.bashrc
13 changes: 0 additions & 13 deletions doc/tutorials/getting_started/getting_started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,6 @@ Optional: add the previous command to your ``.bashrc``: ::
not required and often skipped by advanced users who use more than one
Colcon workspace at a time, but we recommend it for simplicity.

.. _cyclone_dds:

Switch to Cyclone DDS
^^^^^^^^^^^^^^^^^^^^^

As of Sep 26, 2022, the default ROS 2 middleware (RMW) implementation has an issue.
As a workaround, switch to Cyclone DDS.
(Note: this makes all nodes started using this RMW incompatible with any other nodes not using Cyclone DDS.) ::

sudo apt install ros-rolling-rmw-cyclonedds-cpp
# You may want to add this to ~/.bashrc to source it automatically
export RMW_IMPLEMENTATION=rmw_cyclonedds_cpp

Next Step
^^^^^^^^^
Nice job!
Expand Down
1 change: 0 additions & 1 deletion doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Getting Started
---------------
If you haven't already done so, make sure you've completed the steps in :doc:`Getting Started </doc/tutorials/getting_started/getting_started>` or our :doc:`Docker Guide </doc/how_to_guides/how_to_setup_docker_containers_in_ubuntu>`.
If you followed the Docker Guide, also follow the :ref:`create_colcon_workspace` guide onwards to set up the tutorials.
As of Sep 26, 2022, ensure you have :ref:`enabled Cyclone DDS <cyclone_dds>`.

Step 1: Launch the Demo and Configure the Plugin
------------------------------------------------
Expand Down