Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorials for planning pipeline refactoring #793

Closed
wants to merge 7 commits into from
Closed

Update tutorials for planning pipeline refactoring #793

wants to merge 7 commits into from

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 12, 2023 •
edited
Loading

Description

Updates tutorials to changes from moveit/moveit2#2429

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@sjahr sjahr mentioned this pull request Oct 12, 2023
Merged
4 tasks
sea-bass
sea-bass reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're maybe waiting for the MoveIt PR to finalize, but it would be great to expand on the difference between a planning request and response adapters, and show more concrete examples of each in the Planning Adapters tutorial itself.

doc/examples/planning_adapters/planning_adapters_tutorial.rst Outdated Show resolved Hide resolved
doc/how_to_guides/chomp_planner/chomp_planner_tutorial.rst Show resolved Hide resolved
@sjahr sjahr force-pushed the pr-update_for_refactroing_planning_pipeline branch from d141834 to 59d09dc Compare October 30, 2023 18:18
@tylerjw tylerjw marked this pull request as ready for review November 21, 2023 15:12
@tylerjw
Copy link
Member

tylerjw commented Nov 21, 2023

Landed the dependent change in MoveIt; let's finish this one up and get it landed.

@sjahr sjahr changed the title WIP: Update tutorials for planning pipeline refactoring Update tutorials for planning pipeline refactoring Nov 21, 2023
@sjahr sjahr changed the title Update tutorials for planning pipeline refactoring WIP: Update tutorials for planning pipeline refactoring Nov 21, 2023
@sjahr sjahr changed the title WIP: Update tutorials for planning pipeline refactoring Update tutorials for planning pipeline refactoring Nov 30, 2023
@sjahr sjahr requested review from sea-bass and MarqRazz November 30, 2023 14:37
@sjahr
Copy link
Contributor Author

sjahr commented Dec 6, 2023

Closing this in favor of #834

@sjahr sjahr closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

@MarqRazz MarqRazz Awaiting requested review from MarqRazz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjahr @tylerjw @sea-bass @MarqRazz