-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Build Tutorial Image
CI job to only build main against Rolling
#782
Conversation
Thanks for the help @rhaschke! |
The default git context would use the main branch...
You are welcome. The main issue is that the docker/build-push-action uses the current git branch by default: However, fixing this via 40dd10e raises new issues... I'm looking into this shortly, but I will handover to you again, if my time window is over. |
... as we want to access the files in there
Why do you want to build both docker images (for rolling and humble) from the same branch, while they need different source branches: I suggest building the images only from their corresponding branch... I need to continue with other stuff now. |
I agree! If you are okay with the change I made I will fix the description of this PR and also open up one for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted some changes that are not needed anymore if we can just use the git context.
Build Tutorial Image
CI job to only build main against Rolling
…st Rolling (moveit#782)" This reverts commit 8cd7875.
…ng (moveit#782) Co-authored-by: Robert Haschke <[email protected]>
This PR started out trying to fix the CI job
Build Tutorial Image
so that it supported bothhumble
androlling
but as we investigated further it did not make sense to build bothhumble
andmain
when changes were only made to one branch. A follow up PR will be made to thehumble
branch to only build and update the corresponding image.This is an attempt to fix the
Build Tutorial Image
step for humble. It's currently failing with the following error.