Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile on the humble branch to use ROS humble #644

Closed
wants to merge 2 commits into from

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Mar 20, 2023

Description

The backport in e292e4d set the ROS_DISTRO to rolling for the humble branch, which would probably cause issues for users who are trying to go through the MoveIt2 tutorials with MoveIt2 humble. This PR sets the ROS_DISTRO to humble in the Dockerfile so that if users decide to use the Docker setup for the humble tutorials, ROS_DISTRO matches the MoveIt2 version.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@adlarkin adlarkin requested a review from MikeWrock March 20, 2023 20:52
@adlarkin
Copy link
Contributor Author

@MikeWrock CI / humble-source is failing, and I'm not sure why. The error messages in GitHub actions mention struct planning_interface::MotionPlanResponse, but in humble, it looks like the PlanningComponent::Plan API call returns a PlanSolution struct instead. In rolling, the PlanningComponent::Plan API call does appear to return the planning_interface::MotionPlanResponse struct: https://github.com/ros-planning/moveit2/blob/00e10bbebdbef336aacd66fce3f2593844aee834/moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/planning_component.h#L199-L201

So, it seems to me like the error stems from rolling code still being used somewhere. I tried modifying https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/docker-images.yml#L12 to only build humble and not rolling, but I am still seeing the same CI failures. It also looks like humble is used in the industrial_ci for this action (https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/ci.yaml), so I am not sure what is causing this issue at the moment.

@adlarkin
Copy link
Contributor Author

I am going to close this PR - it turns out that for the CI builds that build and push updated tutorial Docker images, the ROS_DISTRO is correctly being set via a build arg (notice how there are build args for both rolling and humble, which means that a humble and rolling image will be built and pushed). The real issue here that's causing some of the humble Docker images to actually have rolling installed is upstream (moveit/moveit2#2035 (comment)). Once the upstream issue is resolved, we will probably need to re-build the tutorial Docker images since they depend on the upstream Docker images.

I have created an issue so that we can track the progress of getting the tutorial images fixed: #646

@adlarkin adlarkin closed this Mar 22, 2023
@adlarkin adlarkin deleted the adlarkin/humble_docker_version_fix branch March 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants