-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pilz examples and update to ROS2 #548
Conversation
9ec0cdd
to
ddbce89
Compare
ddbce89
to
56fba80
Compare
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Everything worked and I like the examples you're providing. My comments are mostly Nit's
Running the examples works fine for me, but I receive this error message when I run
ros2 run moveit2_tutorials pilz_move_group
:
[ERROR] [1669380334.983363669] [moveit_kinematics_base.kinematics_base]: Group 'hand' is not a chain
[ERROR] [1669380334.983375070] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'hand'
[ERROR] [1669380334.983401520] [moveit_kinematics_base.kinematics_base]: Group 'hand' is not a chain
[ERROR] [1669380334.983407822] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'hand'
[ERROR] [1669380334.983417431] [moveit_kinematics_base.kinematics_base]: Group 'hand' is not a chain
[ERROR] [1669380334.983420266] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'hand'
[ERROR] [1669380334.983423983] [moveit_ros.robot_model_loader]: Kinematics solver could not be instantiated for joint group hand.
[ERROR] [1669380334.983717360] [moveit_kinematics_base.kinematics_base]: Group 'panda_arm_hand' is not a chain
[ERROR] [1669380334.983725866] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'panda_arm_hand'
[ERROR] [1669380334.983739692] [moveit_kinematics_base.kinematics_base]: Group 'panda_arm_hand' is not a chain
[ERROR] [1669380334.983743419] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'panda_arm_hand'
[ERROR] [1669380334.983751284] [moveit_kinematics_base.kinematics_base]: Group 'panda_arm_hand' is not a chain
[ERROR] [1669380334.983753769] [kinematics_plugin_loader]: Kinematics solver of type 'kdl_kinematics_plugin/KDLKinematicsPlugin' could not be initialized for group 'panda_arm_hand'
[ERROR] [1669380334.983756654] [moveit_ros.robot_model_loader]: Kinematics solver could not be instantiated for joint group panda_arm_hand.
It does not seem to prevent the demo from working and doesn't happen with the mtc demo. Does that happen to you too?
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/src/pilz_move_group.cpp
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/src/pilz_move_group.cpp
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/src/pilz_move_group.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These isn't from a line that you changed, but I'd appreciate if you added some missing punctuation. Unfortunately, I can't make a suggestion on lines you didn't change, so I've copied the text out below, and put the changes
in code quote format
-
Note that while setting position limits and velocity limits is possible in both the URDF and the parameter server
,
setting acceleration limits is only possible via the parameter server. -
In extension to the common has_acceleration and max_acceleration parameter
s,
we added the ability to also set has_deceleration and max_deceleration (<0.0). -
Currently
,
the calculated trajectory will respect the limits by using the strictest combination of all limits as a common limit for all joints. -
This planner generates fully synchronized
,
point-to-point trajectories with trapezoidal joint velocity profiles. -
start_state/joint_state/(name, position and velocity
)
: joint name/position/velocity -
goal_constraints
:
(goal can be given in joint space or Cartesian space) -
Remove the bold on:
- for a goal in joint space
- for a goal in Cartesian space
-
The
planning result is a joint trajectory. -
In analogy to the MoveGroup action interface
,
the user can plan and execute a moveit_msgs::MotionSequenceRequest through the action server at /sequence_move_group.
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Outdated
Show resolved
Hide resolved
doc/examples/pilz_industrial_motion_planner/pilz_industrial_motion_planner.rst
Show resolved
Hide resolved
The same thing happens with the regular tutorial, e.g. if you run,
So it's not unique to this example. It's an error that happens from trying to load the KDL Kinematics plugin for all available move groups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Add bare-bones Pilz code examples * Fill in Pilz MTC example * Clean up MTC example * Fill in MoveGroup Interface example + more cleanup * Update docs * clang-format * Fix HTML targets * Update code links to use codedir * PR comments * Fix URL (cherry picked from commit 7498cc2) # Conflicts: # CMakeLists.txt
* Pilz examples and update to ROS2 (#548) * Add bare-bones Pilz code examples * Fill in Pilz MTC example * Clean up MTC example * Fill in MoveGroup Interface example + more cleanup * Update docs * clang-format * Fix HTML targets * Update code links to use codedir * PR comments * Fix URL (cherry picked from commit 7498cc2) # Conflicts: # CMakeLists.txt * Fix conflicts from mergify bot --------- Co-authored-by: Sebastian Castro <[email protected]> Co-authored-by: Sebastian Castro <[email protected]>
Description
This PR updates the Pilz industrial motion planner example doc, but also adds two actual examples that show Pilz with MoveGroup Interface and MoveIt Task constructor.
Checklist
Closes #35