Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle continuous joints in getLowerAndUpperLimits (backport #3153) #3155

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 11, 2024

Description

The RevoluteJointModel returns -pi/pi as position joint limits for continuous joints, which are not position bounded.
This PR fixes getLowerAndUpperLimits to check the position_bounded_ flag and return joint limits accordingly.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3153 done by [Mergify](https://mergify.com).

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.45%. Comparing base (be68635) to head (bd1a13f).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
moveit_core/robot_model/src/joint_model_group.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3155      +/-   ##
==========================================
- Coverage   46.13%   44.45%   -1.67%     
==========================================
  Files         483      698     +215     
  Lines       40631    61558   +20927     
  Branches        0     7459    +7459     
==========================================
+ Hits        18740    27359    +8619     
- Misses      21891    34030   +12139     
- Partials        0      169     +169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit e94c891 into jazzy Dec 11, 2024
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3153 branch December 11, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants